Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deadlock with IDEA EAP 2023-3 EAP #1193

Closed
wants to merge 1 commit into from
Closed

fix: Deadlock with IDEA EAP 2023-3 EAP #1193

wants to merge 1 commit into from
+128 −54

Conversation

angelozerr
Copy link
Contributor

fix: Deadlock with IDEA EAP 2023-3 EAP

Fixes #1192

@angelozerr angelozerr force-pushed the deadlock-promise branch 2 times, most recently from 9b154e8 to 6bc31ab Compare October 3, 2023 19:01
@fbricon
Copy link
Contributor

fbricon commented Oct 4, 2023

seems to work. No deadlock in 15 min

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@angelozerr
Copy link
Contributor Author

seems to work. No deadlock in 15 min

Thanks for your feedback.

I indeed fix the freeze problem which comes from cancel of codelens which is done every time. So it doesn't freeze but for the moment codelensare not displayed because of cancel which is done every time, why?

My PR fixes all problem that I have encountered with EAP:

  • freeze when cancel is done (fixed)
  • telemetry which throw an exception when language server is created (I try / catch teh call of telemetry)
  • don't use StringUtils from commons which will be removed

Now I need to understand why codelens are canceled every time.

@fbricon
Copy link
Contributor

fbricon commented Oct 4, 2023

we need to understand why telemetry fails

@angelozerr
Copy link
Contributor Author

I close this since I have create several push to fix main problem with EAP

@angelozerr angelozerr closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock with IDEA EAP 2023-3 EAP
2 participants
@angelozerr @fbricon